Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Suren Baghdasaryan <surenb@xxxxxxxxxx>
Subject: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
From: Peter Xu <peterx@xxxxxxxxxx>
Date: Tue, 18 Apr 2023 19:38:07 -0400
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, hannes@xxxxxxxxxxx, mhocko@xxxxxxxx, josef@xxxxxxxxxxxxxx, jack@xxxxxxx, ldufour@xxxxxxxxxxxxx, laurent.dufour@xxxxxxxxxx, michel@xxxxxxxxxxxxxx, liam.howlett@xxxxxxxxxx, jglisse@xxxxxxxxxx, vbabka@xxxxxxx, minchan@xxxxxxxxxx, dave@xxxxxxxxxxxx, punit.agrawal@xxxxxxxxxxxxx, lstoakes@xxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-team@xxxxxxxxxxx
In-reply-to: <CAJuCfpFyetOXEMB2+b3LRO9-ESdDTdEyOyfUGsr0FbsWJi1-kA@mail.gmail.com>
References: <ZD3Nk0u+nxOT4snZ@casper.infradead.org> <CAJuCfpFPziNK65qpzd5dEYSnoE-94UHAsM-CX080VTTJC5ZZKA@mail.gmail.com> <ZD6oVgIi/yY1+t1L@casper.infradead.org> <CAJuCfpFJ0owZELS2COukb0rHCOpqNMW-x9vVonkhknReZb=Zsg@mail.gmail.com> <ZD6yirD6Ob+1xG32@casper.infradead.org> <ZD6/805XpvfZde0Y@x1n> <CAJuCfpGZAALQbPFGymJOgkMp2knKoos697L8jd1v2jDyBSbdYA@mail.gmail.com> <CAJuCfpFFsKkdnHLSojSo0pP-=nQFiY408tpVDHVy6TpGSv1B9g@mail.gmail.com> <ZD8dj3Tk2b1TWVK5@x1n> <CAJuCfpFyetOXEMB2+b3LRO9-ESdDTdEyOyfUGsr0FbsWJi1-kA@mail.gmail.com>

On Tue, Apr 18, 2023 at 03:58:26PM -0700, Suren Baghdasaryan wrote:
> Sure. How about replacing my prior "Register both successful and
> failed faults in PGFAULT counters." comment with "To preserve the
> behavior of older kernels, PGFAULT counters record both successful and
> failed faults, as opposed to perf counters which ignore failed cases"

Looks good here, thanks!

-- 
Peter Xu

Follow-Ups:
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Suren Baghdasaryan

References:
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Matthew Wilcox
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Suren Baghdasaryan
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Matthew Wilcox
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Suren Baghdasaryan
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Matthew Wilcox
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Peter Xu
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Suren Baghdasaryan
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Suren Baghdasaryan
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Peter Xu
- Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
  - From: Suren Baghdasaryan

Prev by Date: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
Next by Date: Re: [PATCH v10 9/9] KVM: Enable and expose KVM_MEM_PRIVATE
Previous by thread: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
Next by thread: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]