On Tue, Apr 18, 2023 at 10:14:06AM +0800, Hal Feng wrote: > On Mon, 17 Apr 2023 17:22:01 -0700, Stephen Boyd wrote: > > Quoting Conor Dooley (2023-04-17 03:18:35) > >> Aye, just the explicit dependency seems like it'd be less fragile and > >> more obvious in the future. > > > > Agreed. Be explicit so we don't have to hunt down select dependencies. > > With further consideration, on the other hand, if we set `if ARCH_STARFIVE` > here, it can point out that we need the reset driver to boot up JH7110 > besides the clock drivers, and the reset driver is not a necessary option > for compilation test. So the reset driver is independent to the clock > drivers when you doing a compilation test. If ARCH_STARFIVE is enabled, both options (RESET_CONTROLLER & RESET_STARFIVE_JH7110) will be selected & you don't need to worry about people not realising this. Try it out & look at the option in menuconfig. > If we set `if RESET_CONTROLLER` here, the reset driver will be compiled > automatically when (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && > RESET_CONTROLLER [=y] && CLK_STARFIVE_JH7110_SYS [=y]). This is what we want, right? The more often it gets built by randconfig etc the better, especially for archs that are not RISC-V. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
