On Sun, Apr 29, 2012 at 4:00 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Sun, 2012-04-29 at 14:07 +0200, Sasha Levin wrote: >> On Sun, Apr 29, 2012 at 10:22 AM, Eric W. Biederman > >> Exactly twp of the patches (out of 14) are taking updates out of >> locks. I'm quite sure that doing that in the ftrace case is perfectly >> fine, and I'll take a second look at the sched-rt one since there >> indeed might be a race caused due to the patch that I've missed. > > The update of ftrace_enable must be done under the ftrace_lock mutex. > With the exception of ftrace_kill() which is a one shot deal that kills > ftrace updates until a reboot. Understood. A fix for that could be having the sysctl modifying a different var, and having ftrace_enabled from that under a lock, but I'm not sure if it's worth the work for the cleanup. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>