On Tue, Apr 11, 2023 at 01:52:58PM +0300, Mike Rapoport wrote: > On Thu, Mar 30, 2023 at 12:08:12PM -0400, Peter Xu wrote: > > Subject: selftests/mm: Let uffd_handle_page_fault() takes wp parameter > > Nit: ^ take > > > Make the handler optionally apply WP bit when resolving page faults for > > either missing or minor page faults. This move towards removing global > > Nit: ^ moves Will fix. > > > test_uffdio_wp outside of the common code. > > > > For this, slightly abuse uffd_stats to keep one more parameter on whether > > we'd like to resolve page faults with WP bit set. Note that only the name > > is abused, it'll be better to be called uffd_args or similar but let's not > > bother for now. > > Maybe one of the first commits in the series should have been > s/uffd_stats/uffd_args/g, but I realize that it's PITA, so I won't insist. It's fine, I'll add one patch. The rebase does take some more minutes, but it's manageable. I'll drop this paragraph then. Thanks, -- Peter Xu
