Andrew Morton wrote:
On Thu, 26 Apr 2012 11:53:44 +0400
Konstantin Khlebnikov<khlebnikov@xxxxxxxxxx> wrote:
This patchset depends on Johannes Weiner's patch
"mm: memcg: count pte references from every member of the reclaimed hierarchy".
bloat-o-meter delta for patches 2..12
add/remove: 6/6 grow/shrink: 6/14 up/down: 4414/-4625 (-211)
That's the sole effect and intent of the patchset? To save 211 bytes?
This is almost last bunch of cleanups for lru_lock splitting,
code reducing is only nice side-effect.
Also this patchset removes many redundant lruvec relookups.
Now mostly all page-to-lruvec translations are located at the same level
as zone->lru_lock locking. So lru-lock splitting patchset can something like this:
-zone = page_zone(page)
-spin_lock_irq(&zone->lru_lock)
-lruvec = mem_cgroup_page_lruvec(page)
+lruvec = lock_page_lruvec_irq(page)
...
include/linux/memcontrol.h | 16 +--
include/linux/mmzone.h | 14 ++
mm/memcontrol.c | 33 +++--
mm/mmzone.c | 14 ++
mm/page_alloc.c | 8 -
mm/vmscan.c | 277 ++++++++++++++++++++------------------------
6 files changed, 177 insertions(+), 185 deletions(-)
If so, I'm not sure that it is worth the risk and effort?
After lumpy-reclaim removal there a lot of dead or redundant code, maybe someone else
wants to cleanup this code, I specifically sent this set early to avoid conflicts.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email:<a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx</a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>