Re: [PATCH] kmsan: fix a stale comment in kmsan_save_stack_with_flags()

[Alexander Potapenko <glider@xxxxxxxxxx>]

On Mon, Mar 27, 2023 at 5:45 AM Zhen Lei <thunder.leizhen@xxxxxxxxxx> wrote:
>
> After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and
> commit 84172f4bb752 ("mm/page_alloc: combine __alloc_pages and
> __alloc_pages_nodemask"), the comment is no longer accurate.
> Flag '__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the
> comment rather than update it.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx>

>
>         nr_entries = stack_trace_save(entries, KMSAN_STACK_DEPTH, 0);
>
> -       /* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask()). */
> +       /* Don't sleep. */

Thanks for spotting this!