Re: [PATCH -mm V2] do_migrate_pages() calls migrate_to_node() even if task is already on a correct node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/24/2012 02:17 PM, Christoph Lameter wrote:
On Tue, 24 Apr 2012, Larry Woodman wrote:

How does this look:

Could you please send the patches inline? Its difficult to quote the
attachment.


Sorry all of these email clients are different.


diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index f563fa3..b76b49a 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1012,6 +1012,24 @@ int do_migrate_pages(struct mm_struct *mm,
                int dest = 0;

                for_each_node_mask(s, tmp) {
+
+                       /*
+                        * IFF there is an equal number of source and
+ * destination nodes, maintain relative node distance
+                        * even when source and destination nodes overlap.
+ * However, when the node weight is unequal/there are + * a different number of source and destination nodes, + * never move memory out of a source node that is also
+                        * a destination node.
+                        *
+                        * Example: [2,3,4] -> [3,4,5] moves everything.
+                        *          [0-7] - > [3,4,5] moves only 0,1,2,6,7.
+                        */
+
+ if ((nodes_weight(*from_nodes) != nodes_weight(*to_nodes)) &&
+                                               (node_isset(s, *to_nodes)))
+                               continue;
+
                        d = node_remap(s, *from_nodes, *to_nodes);
                        if (s == d)
                                continue;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]