On Thu, Mar 23, 2023 at 04:00:37PM +0100, Pankaj Raghav wrote: > > We don't need to set the error flag. Only some filesystems still use > > the error flag, and orangefs isn't one of them. I'd like to get rid > > of the error flag altogether, and I've sent patches in the past which > > get us a lot closer to that desired outcome. Not sure we're there yet. > > Regardless, generic code doesn't check the error flag. > > Thanks for the explanation. I think found the series you are referring here. > > https://lore.kernel.org/linux-mm/20220527155036.524743-1-willy@xxxxxxxxxxxxx/#t > > I see orangefs is still setting the error flag in orangefs_read_folio(), so > it should be removed at some point? Yes, OrangeFS only sets the error flag, it never checks it, so it never needs to set it. > I also changed mpage to **not set** the error flag in the read path. It does beg > the question whether block_read_full_folio() and iomap_finish_folio_read() should > also follow the suit. Wrong. mpage is used by filesystems which *DO* check the error flag. You can't remove it being set until they're fixed to not check it.
