Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Tue, 21 Mar 2023 16:40:48 +0000
Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Roman Gushchin <roman.gushchin@xxxxxxxxx>, Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>, John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
In-reply-to: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be>
References: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be>

On Tue, Mar 21, 2023 at 09:30:59AM +0100, Geert Uytterhoeven wrote:
> -#if (defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)) || defined(CONFIG_SMP)
> +#if defined(CONFIG_NUMA) || defined(CONFIG_SMP)

I'm amused by the thought of CONFIG_NUMA without CONFIG_SMP.
Is it possible to have one node with memory and a single CPU, then
another node with memory and no CPU?

Follow-Ups:
- Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP
  - From: Dave Hansen
- Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP
  - From: Randy Dunlap

References:
- [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP
  - From: Geert Uytterhoeven

Prev by Date: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file
Next by Date: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file
Previous by thread: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP
Next by thread: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]