Re: [PATCH 09/15] mm: move pgtable_init() to mm/mm_init.c and make it static

To: Mike Rapoport <rppt@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 09/15] mm: move pgtable_init() to mm/mm_init.c and make it static
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Mon, 20 Mar 2023 11:37:42 +0100
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <20230319220008.2138576-10-rppt@kernel.org>
Organization: Red Hat
References: <20230319220008.2138576-1-rppt@kernel.org> <20230319220008.2138576-10-rppt@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 19.03.23 23:00, Mike Rapoport wrote:

From: "Mike Rapoport (IBM)" <rppt@xxxxxxxxxx>

pgtable_init() is only called from mm_core_init().

Move it close to the caller and make it static.

Why not inline it completely into the single caller? I don't see toomuch value of this indirection.


--
Thanks,

David / dhildenb

References:
- [PATCH 00/15] mm: move core MM initialization to mm/mm_init.c
  - From: Mike Rapoport
- [PATCH 09/15] mm: move pgtable_init() to mm/mm_init.c and make it static
  - From: Mike Rapoport