On Sun, Mar 19, 2023 at 02:50:56AM +0000, Matthew Wilcox wrote: > On Sun, Mar 19, 2023 at 12:20:12AM +0000, Lorenzo Stoakes wrote: > > /* for /proc/kcore */ > > -extern long vread(char *buf, char *addr, unsigned long count); > > +extern long vread_iter(char *addr, size_t count, struct iov_iter *iter); > > I don't love the order of the arguments here. Usually we follow > memcpy() and have (dst, src, len). This sometimes gets a bit more > complex when either src or dst need two arguments, but that's not the > case here. Indeed it's not delightful, I did this purely to mimic the order of copy_to_iter() and friends which place iter last, however on second thoughts I think placing iter first would be better here where we have the freedom to order things more sensibly. I'll respin with a fix.
