Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > -static long do_splice_to(struct file *in, loff_t *ppos, > > - struct pipe_inode_info *pipe, size_t len, > > - unsigned int flags) > > +long vfs_splice_read(struct file *in, loff_t *ppos, > > The (pre-existing) long here is odd given that ->splice_read > returns a ssize_t. This might be a good time to fix that up. There's a while lot of places in splice.c that use long rather than ssize_t. I can produce a separate patch that changes them all, but that should perhaps be separate to this. David
