Actually, it seems odd to use a min setting and configure it to map to SYSCTL_ONE to SYSCTL_ONE so just a SYCTL_$(type)_MAX or just the type max would be better and not break old userspace.
On Wed, Mar 8, 2023, 7:56 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:
On Thu, Mar 09, 2023 at 11:42:58AM +0800, ye.xingchen@xxxxxxxxxx wrote:
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Available only when CONFIG_COMPACTION is set. When 1 is written to
> the file, all zones are compacted such that free memory is available
> in contiguous blocks where possible.
> But echo others-parameter > compact_memory, this function will be
> triggered by writing parameters to the interface.
>
> Applied this patch,
> sh/$ echo 1.1 > /proc/sys/vm/compact_memory
> sh/$ sh: write error: Invalid argument
Didn't echo 2 > /proc/sys/vm/compact_memory used to work too?
Why kill that? Did the docs say only 1 was possible? If not
perhaps the docs need to be updated?
Luis
