On Wed, Mar 08, 2023 at 04:29:13PM +0100, Christoph Hellwig wrote: > On Wed, Mar 08, 2023 at 04:18:55PM +0100, Danilo Krummrich wrote: > > Consistency wise I think we should either also export mas_preallocate() or > > don't export the other ones either. > > Please send a patch to drop all unused exports. While that's usually a good rule, it just creates unnecessary friction in this kind of case -- a set of library functions which have only been introduced in the last few months. If they're still unused in a year, sure, let's get rid of the exports.