On 03/07/23 at 11:58am, Michael Ellerman wrote: > "Arnd Bergmann" <arnd@xxxxxxxx> writes: > > On Sun, Mar 5, 2023, at 10:29, Geert Uytterhoeven wrote: > >> On Sun, Mar 5, 2023 at 10:23 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: > >>> Maybe that exact code path is only reachable on x86/ia64? But if so > >>> please explain why. > >>> > >>> Otherwise it looks like this series could break that driver on powerpc > >>> at least. > >> > >> Indeed. > > > > When I last looked into this, I sent a patch to use ioremap() > > on non-x86: > > > > https://lore.kernel.org/all/20191111192258.2234502-1-arnd@xxxxxxxx/ > > OK thanks. > > Baoquan can you add that patch to the start of this series if/when you > post the next version? Sure, will do. Wondering if we need make change to cover powerpc other than x86 and ia64 in Arnd's patch as you and Geert pointed out.