On 01.03.23 03:27, Suren Baghdasaryan wrote:
vp->vma in vma_prepare() is always non-NULL, therefore checking it is
not necessary. Remove the extra check.
Fixes: e8f071350ea5 ("mm/mmap: write-lock VMAs in vma_prepare before modifying them")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <error27@xxxxxxxxx>
It would be great to mention that this simply silences a smatch warning.
Otherwise, one might be mislead that this commit fixes an actual BUG ;)
Link: https://lore.kernel.org/r/202302281802.J93Nma7q-lkp@xxxxxxxxx/
Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
---
Fix cleanly apply over mm-unstable, SHA in "Fixes" is from that tree.
mm/mmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index 0cd3714c2182..0759d53b470c 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -505,8 +505,7 @@ static inline void init_vma_prep(struct vma_prepare *vp,
*/
static inline void vma_prepare(struct vma_prepare *vp)
{
- if (vp->vma)
- vma_start_write(vp->vma);
+ vma_start_write(vp->vma);
if (vp->adj_next)
vma_start_write(vp->adj_next);
/* vp->insert is always a newly created VMA, no need for locking */
Yes, that looks correct.
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
--
Thanks,
David / dhildenb
