I am traveling today but will be testing this tonight or tomorrow
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Sent: Friday, February 24, 2023 2:05:42 PM
To: David Howells <dhowells@xxxxxxxxxx>
Cc: Steven French <Steven.French@xxxxxxxxxxxxx>; Vishal Moola <vishal.moola@xxxxxxxxx>; Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>; Jan Kara <jack@xxxxxxx>; pc <pc@xxxxxx>; Matthew Wilcox <willy@xxxxxxxxxxxxx>; Huang Ying <ying.huang@xxxxxxxxx>; Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>; Xin Hao <xhao@xxxxxxxxxxxxxxxxx>; linux-mm@xxxxxxxxx <linux-mm@xxxxxxxxx>; mm-commits@xxxxxxxxxxxxxxx <mm-commits@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
Subject: [EXTERNAL] Re: [RFC][PATCH] cifs: Fix cifs_writepages_region()
Sent: Friday, February 24, 2023 2:05:42 PM
To: David Howells <dhowells@xxxxxxxxxx>
Cc: Steven French <Steven.French@xxxxxxxxxxxxx>; Vishal Moola <vishal.moola@xxxxxxxxx>; Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>; Jan Kara <jack@xxxxxxx>; pc <pc@xxxxxx>; Matthew Wilcox <willy@xxxxxxxxxxxxx>; Huang Ying <ying.huang@xxxxxxxxx>; Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>; Xin Hao <xhao@xxxxxxxxxxxxxxxxx>; linux-mm@xxxxxxxxx <linux-mm@xxxxxxxxx>; mm-commits@xxxxxxxxxxxxxxx <mm-commits@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
Subject: [EXTERNAL] Re: [RFC][PATCH] cifs: Fix cifs_writepages_region()
[You don't often get email from torvalds@xxxxxxxxxxxxxxxxxxxx. Learn why this is important at
https://aka.ms/LearnAboutSenderIdentification ]
On Fri, Feb 24, 2023 at 10:58 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> I'll apply that minimal fix for now - I think the right thing to do is
> your bigger patch, but that needs more thinking (or at least splitting
> up).
Minimal fix applied - that way I can drop this for now, and we can
discuss the whole "maybe we can just use write_cache_pages()" instead.
Because that _would_ be lovely, even if it's possible that the generic
helper might need some extra love to work better for cifs/afs.
Linus
On Fri, Feb 24, 2023 at 10:58 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> I'll apply that minimal fix for now - I think the right thing to do is
> your bigger patch, but that needs more thinking (or at least splitting
> up).
Minimal fix applied - that way I can drop this for now, and we can
discuss the whole "maybe we can just use write_cache_pages()" instead.
Because that _would_ be lovely, even if it's possible that the generic
helper might need some extra love to work better for cifs/afs.
Linus
