On Mon, Feb 13, 2023 at 2:28 PM Alexander Potapenko <glider@xxxxxxxxxx> wrote: > > On Fri, Feb 10, 2023 at 10:19 PM <andrey.konovalov@xxxxxxxxx> wrote: > > > > From: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > > > Move all interface- and usage-related documentation comments to > > include/linux/stackdepot.h. > > > > It makes sense to have them in the header where they are available to > > the interface users. > > > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx> > > > + * For example, KASAN needs to save allocation and free stack traces for each > > + * object. Storing two stack traces per object requires a lot of memory (e.g. > > + * SLUB_DEBUG needs 256 bytes per object for that). Since allocation and free > > + * stack traces often repeat, using stack depot allows to save about 100x space. > > + * > > + * Stack traces are never removed from stack depot. > ... from the stack depot? I avoided using "the" for stack depot everywhere to make comments a bit shorter, but I don't mind using it. I see that Andrew already added a fix for this. There are other places where "stack depot" is used without "the", but lets save this for future clean-ups too. Thanks!
