On Mon, Feb 13, 2023 at 2:26 PM Alexander Potapenko <glider@xxxxxxxxxx> wrote: > > On Fri, Feb 10, 2023 at 10:18 PM <andrey.konovalov@xxxxxxxxx> wrote: > > > > From: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > > > Clean up comments in include/linux/stackdepot.h and lib/stackdepot.c: > > > > 1. Rework the initialization comment in stackdepot.h. > > 2. Rework the header comment in stackdepot.c. > > 3. Various clean-ups for other comments. > > > > Also adjust whitespaces for find_stack and depot_alloc_stack call sites. > > > > No functional changes. > > > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx> > > > - * Instead, stack depot maintains a hashtable of unique stacktraces. Since alloc > > - * and free stacks repeat a lot, we save about 100x space. > > - * Stacks are never removed from depot, so we store them contiguously one after > > - * another in a contiguous memory allocation. > > + * For example, KASAN needs to save allocation and free stack traces for each > > s/free/deallocation, maybe? (Here and below) Either way looks good to me. The patches are in mm-stable now though, so lets save this change for another potential set of clean-ups. Thank you!
