On Thu, Feb 16, 2023, at 16:02, Baoquan He wrote: > On 02/16/23 at 01:50pm, Matthew Wilcox wrote: > It's not if including asm-generic/iomap.h. The ARCH_HAS_IOREMAP_xx is to > avoid redefinition there. > > include/asm-generic/iomap.h: > ---- > #ifndef ARCH_HAS_IOREMAP_WC > #define ioremap_wc ioremap > #endif I'd change that to the usual '#ifndef ioremap_wc' in that case. Arnd