On Thu, Feb 16, 2023, at 15:47, Baoquan He wrote: > On 02/16/23 at 01:53pm, Arnd Bergmann wrote: >> On Thu, Feb 16, 2023, at 13:34, Baoquan He wrote: >> I see that there are only two callers of {devm_,}ioremap_uc() left in the >> tree, so maybe we can even take that final step and remove it from >> the interface. Maybe we can revisit [1] as part of this series. > > I see now. Christoph Hellwig ever mentioned in v2 reviewing, I > didn't get why. Thanks for the details. > https://lore.kernel.org/all/YwHX98KBEnZw9t6e@xxxxxxxxxxxxx/T/#u > > I am not sure if it's OK to do the change in this patchset, maybe > another patch? Yes, a separate patch would be ideal. If you do the same change in more than one architecture (other than ia64 and x86), you can combine those into one patch. Arnd