Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes: > On 2/11/23 04:50, Stefan Roesch wrote: >> Document general_progit knob. > > Book about Git :); it should have been general_profit. > Thanks, Fixed. >> diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-ksm b/Documentation/ABI/testing/sysfs-kernel-mm-ksm >> index d244674a9480..7768e90f7a8f 100644 >> --- a/Documentation/ABI/testing/sysfs-kernel-mm-ksm >> +++ b/Documentation/ABI/testing/sysfs-kernel-mm-ksm >> @@ -51,3 +51,11 @@ Description: Control merging pages across different NUMA nodes. >> >> When it is set to 0 only pages from the same node are merged, >> otherwise pages from all nodes can be merged together (default). >> + >> +What: /sys/kernel/mm/ksm/general_profit >> +Date: January 2023 >> +KernelVersion: 6.1 >> +Contact: Linux memory management mailing list <linux-mm@xxxxxxxxx> >> +Description: Measure how effective KSM is. >> + general_profit: how effective is KSM. The formula for the >> + calculation is in Documentation/admin-guide/mm/ksm.rst. >> diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst >> index f160f9487a90..5c4daf44d79d 100644 >> --- a/Documentation/admin-guide/mm/ksm.rst >> +++ b/Documentation/admin-guide/mm/ksm.rst >> @@ -159,6 +159,8 @@ stable_node_chains_prune_millisecs >> >> The effectiveness of KSM and MADV_MERGEABLE is shown in ``/sys/kernel/mm/ksm/``: >> >> +general_profit >> + how effective is KSM. The calculation is explained below. >> pages_shared >> how many shared pages are being used >> pages_sharing > > LGTM, thanks! > > Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>