Re: [PATCH v15 05/17] overlayfs: Implement splice-read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miklos Szeredi <miklos@xxxxxxxxxx>
Subject: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Wed, 15 Feb 2023 15:53:23 +0000
Cc: David Howells <dhowells@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, linux-unionfs@xxxxxxxxxxxxxxx
In-reply-to: <CAJfpegt5OurEve+TvzaXRVZSCv0in8_7whMYGsMDdDd2EjiBNQ@mail.gmail.com>
References: <20230214171330.2722188-1-dhowells@redhat.com> <20230214171330.2722188-6-dhowells@redhat.com> <CAJfpegshWgUYZLc5v-Vwf6g3ZGmfnHsT_t9JLwxFoV8wPrvBnA@mail.gmail.com> <3370085.1676475658@warthog.procyon.org.uk> <CAJfpegt5OurEve+TvzaXRVZSCv0in8_7whMYGsMDdDd2EjiBNQ@mail.gmail.com>

On Wed, Feb 15, 2023 at 04:50:04PM +0100, Miklos Szeredi wrote:
> Looks good.  One more suggestion: add a vfs_splice() helper and use
> that from do_splice_to() as well.

I really hate call_read_iter() etc.  Please don't perpetuate that
pattern.

Follow-Ups:
- Re: [PATCH v15 05/17] overlayfs: Implement splice-read
  - From: Miklos Szeredi
- Re: [PATCH v15 05/17] overlayfs: Implement splice-read
  - From: Christoph Hellwig

References:
- [PATCH v14 00/17] iov_iter: Improve page extraction (pin or just list)
  - From: David Howells
- [PATCH v14 05/17] overlayfs: Implement splice-read
  - From: David Howells
- Re: [PATCH v14 05/17] overlayfs: Implement splice-read
  - From: Miklos Szeredi
- [PATCH v15 05/17] overlayfs: Implement splice-read
  - From: David Howells
- Re: [PATCH v15 05/17] overlayfs: Implement splice-read
  - From: Miklos Szeredi

Prev by Date: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
Next by Date: Re: [PATCH v14 01/12] splice: Fix O_DIRECT file read splice to avoid reversion of ITER_PIPE
Previous by thread: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
Next by thread: Re: [PATCH v15 05/17] overlayfs: Implement splice-read
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]