On Tue, 14 Feb 2023, Yang Shi wrote: > > Changelog: > RFC -> v2: > * Added callback variant for page bulk allocator and mempool bulk allocator > per Mel Gorman. > * Used the callback version in dm-crypt driver. > * Some code cleanup and refactor to reduce duplicate code. > > rfc: https://lore.kernel.org/linux-mm/20221005180341.1738796-1-shy828301@xxxxxxxxx/ Hi This seems like unneeded complication to me. We have alloc_pages(), it can allocate multiple pages efficiently, so why not use it? I suggest to modify crypt_alloc_buffer() to use alloc_pages() and if alloc_pages() fails (either because the system is low on memory or because memory is too fragmented), fall back to the existing code that does mempool_alloc(). Mikulas
