On Fri, Feb 10, 2023 at 10:18 PM <andrey.konovalov@xxxxxxxxx> wrote: > > From: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > The current implementation of the extra_bits interface is confusing: > passing extra_bits to __stack_depot_save makes it seem that the extra > bits are somehow stored in stack depot. In reality, they are only > embedded into a stack depot handle and are not used within stack depot. > > Drop the extra_bits argument from __stack_depot_save and instead provide > a new stack_depot_set_extra_bits function (similar to the exsiting > stack_depot_get_extra_bits) that saves extra bits into a stack depot > handle. > > Update the callers of __stack_depot_save to use the new interace. > > This change also fixes a minor issue in the old code: __stack_depot_save > does not return NULL if saving stack trace fails and extra_bits is used. > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx>
