On Fri, Feb 10, 2023 at 10:18 PM <andrey.konovalov@xxxxxxxxx> wrote: > > From: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > depot_init_pool has two call sites: > > 1. In depot_alloc_stack with a potentially NULL prealloc. > 2. In __stack_depot_save with a non-NULL prealloc. > > At the same time depot_init_pool can only return false when prealloc is > NULL. > > As the second call site makes sure that prealloc is not NULL, the WARN_ON > there can never trigger. Thus, drop the WARN_ON and also move the prealloc > check from depot_init_pool to its first call site. > > Also change the return type of depot_init_pool to void as it now always > returns true. > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx>
