Re: [PATCH -mm] mm: percpu: fix incorrect size in pcpu_obj_full_size()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 10, 2023 at 03:49:47PM +0000, Yafang Shao wrote:
> The extra space which is used to store the obj_cgroup membership is only
> valid when kmemcg is enabled. The kmemcg can be disabled via the kernel
> parameter "cgroup.memory=nokmem" at runtime.
> This helper is also used in non-memcg code, for example the tracepoint,
> so we should fix it.
> 
> It was found by code review when I was implementing bpf memory usage[1].
> No real issue happens in production environment.

Probably not a stable material, but nice to have it fixed. Thanks!

> 
> [1]. https://lwn.net/Articles/921991/
> 
> Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>
> Cc: Dennis Zhou <dennis@xxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Christoph Lameter <cl@xxxxxxxxx>
> Cc: Roman Gushchin <roman.gushchin@xxxxxxxxx>
> Cc: Vasily Averin <vvs@xxxxxxxxxx>

Reviewed-by: Roman Gushchin <roman.gushchin@xxxxxxxxx>

Thanks!




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux