Re: [PATCH v2 02/13] mm/gup: remove obsolete FOLL_LONGTERM comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24.01.23 21:34, Jason Gunthorpe wrote:
These days FOLL_LONGTERM is not allowed at all on any get_user_pages*()
functions, it must be only be used with pin_user_pages*(), plus it now has
universal support for all the pin_user_pages*() functions.

Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
---
  include/linux/mm_types.h | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index a689198caf7408..8971a40c120e38 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -1052,12 +1052,6 @@ typedef unsigned int __bitwise zap_flags_t;
   * specifically failed.  Filesystem pages are still subject to bugs and use of
   * FOLL_LONGTERM should be avoided on those pages.
   *
- * FIXME: Also NOTE that FOLL_LONGTERM is not supported in every GUP call.
- * Currently only get_user_pages() and get_user_pages_fast() support this flag
- * and calls to get_user_pages_[un]locked are specifically not allowed.  This
- * is due to an incompatibility with the FS DAX check and
- * FAULT_FLAG_ALLOW_RETRY.
- *
   * In the CMA case: long term pins in a CMA region would unnecessarily fragment
   * that region.  And so, CMA attempts to migrate the page before pinning, when
   * FOLL_LONGTERM is specified.

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux