Jonathan Cameron wrote:
> On Sun, 05 Feb 2023 17:02:56 -0800
> Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>
> > Expand the region creation infrastructure to enable 'ram'
> > (volatile-memory) regions. The internals of create_pmem_region_store()
> > and create_pmem_region_show() are factored out into helpers
> > __create_region() and __create_region_show() for the 'ram' case to
> > reuse.
> >
> > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Entirely trivial comments inline.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
[..]
> > @@ -1727,29 +1762,37 @@ static ssize_t create_pmem_region_store(struct device *dev,
> > {
> > struct cxl_root_decoder *cxlrd = to_cxl_root_decoder(dev);
> > struct cxl_region *cxlr;
> > - int id, rc;
> > + int rc, id;
> >
> > rc = sscanf(buf, "region%d\n", &id);
> > if (rc != 1)
> > return -EINVAL;
> >
> > - rc = memregion_alloc(GFP_KERNEL);
> > - if (rc < 0)
> > - return rc;
> > + cxlr = __create_region(cxlrd, CXL_DECODER_PMEM, id);
> > + if (IS_ERR(cxlr))
> > + return PTR_ERR(cxlr);
>
> I'd have a blank line here - see below.
>
[..]
> > if (IS_ERR(cxlr))
> > return PTR_ERR(cxlr);
> > -
>
> Just so you know I read to the end!
>
> Spurious unrelated white space change :)
...and I can't even blame that on clang-format! Will fix.
