Re: [PATCH 00/18] CXL RAM and the 'Soft Reserved' => 'System RAM' default

[Davidlohr Bueso <dave@xxxxxxxxxxxx>]

On Mon, 06 Feb 2023, Dan Williams wrote:

> Gregory Price wrote:
> [..]
> > Leverage the same QEMU branch, machine, and configuration as my prior
> > tests, i'm now experiencing a kernel panic on boot.  Will debug a bit
> > in the morning, but here is the stack trace i'm seeing
> >
> > Saw this in both 1 and 2 root port configurations
> >
> > (note: I also have the region reset issue previously discussed on top of
> > your branch).
> >
> > QEMU configuration:
> >
> > sudo /opt/qemu-cxl/bin/qemu-system-x86_64 \
> > -drive file=/var/lib/libvirt/images/cxl.qcow2,format=qcow2,index=0,media=disk,id=hd \
> > -m 2G,slots=4,maxmem=4G \
> > -smp 4 \
> > -machine type=q35,accel=kvm,cxl=on \
> > -enable-kvm \
> > -nographic \
> > -device pxb-cxl,id=cxl.0,bus=pcie.0,bus_nr=52 \
> > -device cxl-rp,id=rp0,bus=cxl.0,chassis=0,port=0,slot=0 \
> > -object memory-backend-file,id=mem0,mem-path=/tmp/mem0,size=1G,share=true \
> > -device cxl-type3,bus=rp0,volatile-memdev=mem0,id=cxl-mem0 \
> > -M cxl-fmw.0.targets.0=cxl.0,cxl-fmw.0.size=1G
> [..]
> > [   15.162837] RIP: 0010:bus_add_device+0x5b/0x150
>
> I suspect cxl_bus_type is not intialized yet. I think this should
> address it:

Yep, thanks.

> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 0faeb1ffc212..6fe00702327f 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -2011,6 +2011,6 @@ static void cxl_core_exit(void)
> 	debugfs_remove_recursive(cxl_debugfs);
> }
>
> -module_init(cxl_core_init);
> +subsys_initcall(cxl_core_init);
> module_exit(cxl_core_exit);
> MODULE_LICENSE("GPL v2");