[linux-next:master 4266/10565] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:62:18: warning: variable 'cursor_bpp' set but not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   129af770823407ee115a56c69a04b440fd2fbe61
commit: 238debcaebe44704887d403157a4d0bd6181fdd9 [4266/10565] drm/amd/display: Use DML for MALL SS and Subvp allocation calculations
config: arm64-randconfig-r011-20230206 (https://download.01.org/0day-ci/archive/20230206/202302062224.ByzeTXh1-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=238debcaebe44704887d403157a4d0bd6181fdd9
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 238debcaebe44704887d403157a4d0bd6181fdd9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c: In function 'dcn32_helper_calculate_mall_bytes_for_cursor':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:62:18: warning: variable 'cursor_bpp' set but not used [-Wunused-but-set-variable]
      62 |         uint32_t cursor_bpp = 4;
         |                  ^~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.h:29,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c:27:
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h: At top level:
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:137:22: warning: 'SYNAPTICS_DEVICE_ID' defined but not used [-Wunused-const-variable=]
     137 | static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
         |                      ^~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:134:17: warning: 'DP_SINK_BRANCH_DEV_NAME_7580' defined but not used [-Wunused-const-variable=]
     134 | static const u8 DP_SINK_BRANCH_DEV_NAME_7580[] = "7580\x80u";
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:132:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
     132 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5};
         |                      ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:131:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
     131 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3};
         |                      ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:36,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:29,
                    from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29:
   drivers/gpu/drm/amd/amdgpu/../display/dc/dc_hdmi_types.h:53:22: warning: 'dp_hdmi_dongle_signature_str' defined but not used [-Wunused-const-variable=]
      53 | static const uint8_t dp_hdmi_dongle_signature_str[] = "DP-HDMI ADAPTOR";
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/cursor_bpp +62 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource_helpers.c

    54	
    55	uint32_t dcn32_helper_calculate_mall_bytes_for_cursor(
    56			struct dc *dc,
    57			struct pipe_ctx *pipe_ctx,
    58			bool ignore_cursor_buf)
    59	{
    60		struct hubp *hubp = pipe_ctx->plane_res.hubp;
    61		uint32_t cursor_size = hubp->curs_attr.pitch * hubp->curs_attr.height;
  > 62		uint32_t cursor_bpp = 4;
    63		uint32_t cursor_mall_size_bytes = 0;
    64	
    65		switch (pipe_ctx->stream->cursor_attributes.color_format) {
    66		case CURSOR_MODE_MONO:
    67			cursor_size /= 2;
    68			cursor_bpp = 4;
    69			break;
    70		case CURSOR_MODE_COLOR_1BIT_AND:
    71		case CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA:
    72		case CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA:
    73			cursor_size *= 4;
    74			cursor_bpp = 4;
    75			break;
    76	
    77		case CURSOR_MODE_COLOR_64BIT_FP_PRE_MULTIPLIED:
    78		case CURSOR_MODE_COLOR_64BIT_FP_UN_PRE_MULTIPLIED:
    79			cursor_size *= 8;
    80			cursor_bpp = 8;
    81			break;
    82		}
    83	
    84		/* only count if cursor is enabled, and if additional allocation needed outside of the
    85		 * DCN cursor buffer
    86		 */
    87		if (pipe_ctx->stream->cursor_position.enable && (ignore_cursor_buf ||
    88				cursor_size > 16384)) {
    89			/* cursor_num_mblk = CEILING(num_cursors*cursor_width*cursor_width*cursor_Bpe/mblk_bytes, 1)
    90			 * Note: add 1 mblk in case of cursor misalignment
    91			 */
    92			cursor_mall_size_bytes = ((cursor_size + DCN3_2_MALL_MBLK_SIZE_BYTES - 1) /
    93					DCN3_2_MALL_MBLK_SIZE_BYTES + 1) * DCN3_2_MALL_MBLK_SIZE_BYTES;
    94		}
    95	
    96		return cursor_mall_size_bytes;
    97	}
    98	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux