Hi Frederic, I love your patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on horms-ipvs-next/master horms-ipvs/master linus/master v6.2-rc6 next-20230203] [cannot apply to paulmck-rcu/dev] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Frederic-Weisbecker/sched-isolation-Merge-individual-nohz_full-features-into-a-common-housekeeping-flag/20230204-072510 patch link: https://lore.kernel.org/r/20230203232409.163847-3-frederic%40kernel.org patch subject: [PATCH 2/2] sched/isolation: Add cpu_is_isolated() API config: x86_64-randconfig-a001 (https://download.01.org/0day-ci/archive/20230205/202302051316.1kdX7ylk-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/89596a035dc10e00cb66d4e75e49d69b75413807 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Frederic-Weisbecker/sched-isolation-Merge-individual-nohz_full-features-into-a-common-housekeeping-flag/20230204-072510 git checkout 89596a035dc10e00cb66d4e75e49d69b75413807 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/pci/pci-driver.c:15: >> include/linux/sched/isolation.h:58:10: error: implicit declaration of function 'housekeeping_test_cpu' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN) || ^ include/linux/sched/isolation.h:58:10: note: did you mean 'housekeeping_any_cpu'? include/linux/sched/isolation.h:27:19: note: 'housekeeping_any_cpu' declared here static inline int housekeeping_any_cpu(enum hk_type type) ^ 1 error generated. -- In file included from kernel/sched/fair.c:38: >> include/linux/sched/isolation.h:58:10: error: implicit declaration of function 'housekeeping_test_cpu' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN) || ^ include/linux/sched/isolation.h:58:10: note: did you mean 'housekeeping_any_cpu'? include/linux/sched/isolation.h:27:19: note: 'housekeeping_any_cpu' declared here static inline int housekeeping_any_cpu(enum hk_type type) ^ kernel/sched/fair.c:688:5: warning: no previous prototype for function 'sched_update_scaling' [-Wmissing-prototypes] int sched_update_scaling(void) ^ kernel/sched/fair.c:688:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int sched_update_scaling(void) ^ static 1 warning and 1 error generated. vim +/housekeeping_test_cpu +58 include/linux/sched/isolation.h 55 56 static inline bool cpu_is_isolated(int cpu) 57 { > 58 return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN) || 59 !housekeeping_test_cpu(cpu, HK_TYPE_KERNEL_NOISE); 60 } 61 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
