On 2/3/2023 10:02 PM, Matthew Wilcox wrote: > On Fri, Feb 03, 2023 at 09:16:34PM +0800, Yin Fengwei wrote: >> +++ b/mm/rmap.c >> @@ -1303,31 +1303,44 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, >> } >> >> /** >> - * page_add_file_rmap - add pte mapping to a file page >> - * @page: the page to add the mapping to >> + * flio_add_file_rmap_range - add pte mapping to a sub page range of a folio > > Typo -- missing 'o'. And there's that word "sub" still ;-) OK. > >> + * @folio: The filio to add the mapping to > > s/filio/folio/ OK. > >> + * @start: The first page index in folio > > Better to describe it as the 'first page number' -- index is usually > used as file index, ie offset within the file, rather than offset within > the folio. OK. > >> + * @nr_pages: The number of pages for pte mapping adding > > Maybe "The number of pages which will be mapped"? Sure. Regards Yin, Fengwei >
