On 2/3/2023 9:53 PM, Matthew Wilcox wrote: > On Fri, Feb 03, 2023 at 09:16:33PM +0800, Yin Fengwei wrote: >> filemap_map_folio_range() maps partial/full folio. Comparing to >> original filemap_map_pages(), it batched updates refcount and >> get minor performance improvement for large folio. >> >> a self cooked will-it-scale.page_fault3 like app (change file >> write fault to read fault) with xfs filesystem got 2% performance >> gain. > > Please delete folio_more_pages() as part of this patch; this was the > only caller. OK. Will update in next version. > >> + ret |= filemap_map_folio_range(vmf, folio, >> + xas.xa_index - folio->index, addr, nr_pages); > > Sorry to nitpick, but there's an extra space between |= and > filemap_map_folio_range() here. OK. Will update in next version. Regards Yin, Fengwei >
