On Wed, 11 Apr 2012, Linus Torvalds wrote: > > I am not familiar with the code much but a trivial call chain walk up to > > write_dev_supers (in btrfs) shows that we do not check for the return value > > from __getblk so we would nullptr and there might be more. > > I guess these need some treat before the BUG might be removed, right? > > Well, realistically, isn't BUG() as bad as a NULL pointer dereference? Well, there still could be weirdos out there not setting sys.vm.mmap_min_addr to something sane. For those, NULL pointer dereference could have worse consequences than BUG (unlikely in this particular case, yes). -- Jiri Kosina SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>