Re: [PATCH -mm] remove swap token code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(4/10/12 9:48 PM), Johannes Weiner wrote:
On Mon, Apr 09, 2012 at 11:32:01AM -0400, Rik van Riel wrote:
The swap token code no longer fits in with the current VM model.
It does not play well with cgroups or the better NUMA placement
code in development, since we have only one swap token globally.

It also has the potential to mess with scalability of the system,
by increasing the number of non-reclaimable pages on the active
and inactive anon LRU lists.

Last but not least, the swap token code has been broken for a
year without complaints.  This suggests we no longer have much
use for it.

The days of sub-1G memory systems with heavy use of swap are
over. If we ever need thrashing reducing code in the future,
we will have to implement something that does scale.

Signed-off-by: Rik van Riel<riel@xxxxxxxxxx>

Acked-by: Johannes Weiner<hannes@xxxxxxxxxxx>

Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>

I really think swap token is sane. but now (after merging Johannes's memcg naturalization)
it don't work and we don't have a reason to maintain _current_ implementaion.



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]