On 1/30/2023 9:21 PM, Matthew Wilcox wrote: > On Mon, Jan 30, 2023 at 08:55:00PM +0800, Yin Fengwei wrote: >> Allow the batched page table population added to fault >> around handler and benefit both file read and shared >> fault. >> >> Signed-off-by: Yin Fengwei <fengwei.yin@xxxxxxxxx> > > Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > > Perhaps the performance effect of this patch should go into this patch's > description since it's so dramatic? I would change-log this as: > > The shared fault handler can also benefit from fault-around. While it > is uncommon to write to MAP_SHARED files, applications that do will see > a huge benefit with will-it-scale:page_fault3 (shared file write fault) > improving by 375%. Thanks a lot for reviewing. I will update the commit message. Regards Yin, Fengwei
