Hi Arnd, On Tuesday, April 10, 2012 1:47 PM Arnd Bergmann wrote: > On Tuesday 10 April 2012, Marek Szyprowski wrote: > > This patch modifies dma-mapping implementation on ARM architecture to > > use common dma_map_ops structure and asm-generic/dma-mapping-common.h > > helpers. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > > Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > --- > > arch/arm/Kconfig | 1 + > > arch/arm/include/asm/device.h | 1 + > > arch/arm/include/asm/dma-mapping.h | 196 +++++------------------------------- > > arch/arm/mm/dma-mapping.c | 148 ++++++++++++++++----------- > > 4 files changed, 115 insertions(+), 231 deletions(-) > > Looks good in principle. One question: Now that many of the functions are only > used in the dma_map_ops, can you make them 'static' instead? Some of these non static functions (mainly arm_dma_*_sg_* family) are also used by dma bounce code introduced in the next patch, that's why I left them without static attribute. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>