On Thu, Jan 26, 2023 at 5:58 AM Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Jan 25, 2023 at 03:35:49PM -0800, Suren Baghdasaryan wrote: > > vm_flags are among VMA attributes which affect decisions like VMA merging > > and splitting. Therefore all vm_flags modifications are performed after > > taking exclusive mmap_lock to prevent vm_flags updates racing with such > > operations. Introduce modifier functions for vm_flags to be used whenever > > flags are updated. This way we can better check and control correct > > locking behavior during these updates. > > > > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> > > With or without the suggested rename; > > Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> Thanks! I'll make the renames and repost the patchset. vm_flags_init(), vm_flags_reset(), etc. sounds like a good naming for this. > > -- > Mel Gorman > SUSE Labs