Re: [PATCH 2/2] mm: compaction: allow isolation of lower order buddy pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 05, 2012 at 06:32:13PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Allow lower order buddy pages in suitable_migration_target()
> so isolate_freepages() can isolate them as free pages during
> compaction_alloc() phase.
> 
> Cc: Mel Gorman <mgorman@xxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>

Nak.

This patch depends on patch 1 to scan every page in isolate_freepages()
and I explained why that is a problem already. That aside, a side-effect
of this is that movable pages can get migrated to MIGRATE_UNMOVABLE
and MIGRATE_RECLAIMABLE pageblocks. This will have a negative impact on
fragmentation avoidance. In your particular use-case it will slightly
increase allocation success rates early in the lifetime of the system at
the cost of degrading success rates later.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]