David Hildenbrand <david@xxxxxxxxxx> wrote: > > Provide a helper in the get_user_pages code to drop a pin or a ref on a > > page based on being given FOLL_GET or FOLL_PIN in its flags argument or do > > nothing if neither is set. > > Does the FOLL_GET part still apply to this patch set? Yes. Christoph insisted that the bio conversion patch be split up. That means there's an interval where you can get FOLL_GET from that. However, since Jason wants to hide FOLL_PUT, this is going to have to be removed and the switching done in the bio code for the bio case (until that reduces to just pinning) and the skbuff cleanup code (when that is eventually done - that will have the possibility of skbuffs comprising a mix of ref'd, pinned and unpinned data, albeit in separate fragments; I've posted patches that illustrate this[1]). David https://lore.kernel.org/all/167391047703.2311931.8115712773222260073.stgit@xxxxxxxxxxxxxxxxxxxxxx/ [1] Patches 33-34
