On 1/23/23 09:58, Jason Gunthorpe wrote: ...
How about, I made a patch to move all the internal FOLL_ flags into mm/internal.h ?
Yes, after thinking through the internal and external APIs, and the FOLL_* situation, that sounds like the best overall approach right now, IMHO. I also considered whether adding some naming hints on top (suffixes such as _INTERNAL) might help, but so far, it looks like it would add more clutter than is justified. Instead, just looking at where the FOLL_* flag is defined seems like it could be enough. And there aren't *too* many flags, after all. thanks, -- John Hubbard NVIDIA
