On 1/17/23 07:58, Jason Gunthorpe wrote: > There are only two callers, both can handle the common return code: > > - get_user_page_fast_only() checks == 1 > > - gfn_to_page_many_atomic() already returns -1, and the only caller > checks for -ve Maybe "checks for negative return values" ? > > Remove the restriction against returning negative values. > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> > --- > mm/gup.c | 17 +---------------- > 1 file changed, 1 insertion(+), 16 deletions(-) > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx> thanks, -- John Hubbard NVIDIA