On Fri, Jan 20, 2023 at 08:41:37AM +0100, Christoph Hellwig wrote: > On Thu, Jan 19, 2023 at 07:48:48PM +0100, Uladzislau Rezki wrote: > > A small nit here. IMHO, a va_remove_mappings() should be > > renamed back to vm_remove_mappings() since after this patch > > it starts deal with "struct vm_struct". > > > > OK. After checking all patches this function will be renamed > > anyway to vm_reset_perms(). > > І could rename it. It's not that much more churn given that > the prototype is touched anyway. > A new vm_reset_perms() name matches the VM_FLUSH_RESET_PERMS flag what, i think, is totally fine. -- Uladzislau Rezki