On 1/19/23 13:19, John Hubbard wrote: ...
long __get_user_pages_locked(struct mm_struct *mm, unsigned long start, @@ -1343,7 +1352,7 @@ long __get_user_pages_locked(struct mm_struct *mm, unsigned int flags)
Shoot, this diff won't apply without a fix-up, because the above is actually supposed to be: static __always_inline long __get_user_pages_locked(struct mm_struct *mm, ...but I had a local patch applied on top, to remove all the static keywords for functions in gup.c, thus in turn allowing my function graphing tool to work. It draws helpful pictures of the evolving call graph, but "static" hides things from it, due to using gcc's output for this. And since most gup.c functions are static, it was awkward... Anyway, apologies for letting the tooling noise leak into my response. "It will never happen again." I hope. :) thanks, -- John Hubbard NVIDIA
