On Wed, Jan 18, 2023 at 07:59:21AM -0800, Linus Torvalds wrote: > We don't silence it - for a kernel address that turns into an all-ones > address, the the _ASM_EXTABLE() will still cause the -EFAULT due to > the page fault. > But it's not the high bit set case that is the problem here. Yes, and the explicit bad_get_user jump would not print the message and now with _UA removed it won't either (I seem to have my wires crossed just now). > The problem is a "positive" address that is non-canonical. > > Testing against TASK_SIZE_MAX would catch non-canonical addresses > before the access, and we'd return -EFAULT. > > But now that we don't test against TASK_SIZE_MAX any more, > non-canonical accesses will cause a GP fault, and *that* message is > what we want to silence. Right, but I was thinking that we'd explicitly allowed those because with LAM enabled we'd actually accept those addresses. > We'll still return -EFAULT, of course, we're just getting rid of the > > WARN_ONCE(trapnr == X86_TRAP_GP, > "General protection fault in user access. > Non-canonical address?"); > > issue that comes from not being so exact about the address limit any more. Ah indeed, so for !LAM we'd now print the message were we would not before (the whole TASK_SIZE_MAX+ range). OK, agreed.
