Re: [PATCH] mm/hugetlb: convert get_hwpoison_huge_page() to folios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sidhartha Kumar <sidhartha.kumar@xxxxxxxxxx>
Subject: Re: [PATCH] mm/hugetlb: convert get_hwpoison_huge_page() to folios
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Tue, 17 Jan 2023 18:45:33 +0000
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, songmuchun@xxxxxxxxxxxxx, mike.kravetz@xxxxxxxxxx, naoya.horiguchi@xxxxxxx
In-reply-to: <20230117182917.73729-1-sidhartha.kumar@oracle.com>
References: <20230117182917.73729-1-sidhartha.kumar@oracle.com>

On Tue, Jan 17, 2023 at 10:29:17AM -0800, Sidhartha Kumar wrote:
> -	if (get_page_unless_zero(head)) {
> -		if (head == compound_head(page))
> +	if (folio_try_get(folio)) {
> +		if (&folio->page == compound_head(page))

I'd rather express this as:

		if (folio == page_folio(page))

as we do in mm/gup.c

References:
- [PATCH] mm/hugetlb: convert get_hwpoison_huge_page() to folios
  - From: Sidhartha Kumar

Prev by Date: Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)
Next by Date: Re: [PATCH 41/41] mm: replace rw_semaphore with atomic_t in vma_lock
Previous by thread: [PATCH] mm/hugetlb: convert get_hwpoison_huge_page() to folios
Next by thread: Re: [PATCH] mm/hugetlb: convert get_hwpoison_huge_page() to folios
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux