On Mon, Jan 16, 2023 at 12:16:13PM -0800, Andrew Morton wrote:
> On Mon, 16 Jan 2023 19:39:01 +0000 Jiaqi Yan <jiaqiyan@xxxxxxxxxx> wrote:
...
> > @@ -1227,6 +1227,39 @@ static struct page_state error_states[] = {
> > #undef slab
> > #undef reserved
> >
> > +static void update_per_node_mf_stats(unsigned long pfn,
> > + enum mf_result result)
> > +{
> > + int nid = MAX_NUMNODES;
> > + struct memory_failure_stats *mf_stats = NULL;
> > +
> > + nid = pfn_to_nid(pfn);
> > + if (unlikely(nid < 0 || nid >= MAX_NUMNODES)) {
> > + WARN_ONCE(1, "Memory failure: pfn=%#lx, invalid nid=%d", pfn, nid);
> > + return;
> > + }
> > +
> > + mf_stats = &NODE_DATA(nid)->mf_stats;
> > + switch (result) {
> > + case MF_IGNORED:
> > + ++mf_stats->pages_ignored;
>
> What is the locking here, to prevent concurrent increments?
mf_mutex should prevent the race.
Thanks,
Naoya Horiguchi
