On Fri, Jan 13, 2023 at 03:47:31PM +0700, Bagas Sanjaya wrote:
> On Fri, Jan 13, 2023 at 03:50:45PM +0800, yang.yang29@xxxxxxxxxx wrote:
> > This patch updates shadow_nodes of anonymous page when swap
> > cache is add or delete.
>
> By what?
This is not a helpful question.
> > @@ -252,6 +256,8 @@ void clear_shadow_from_swap_cache(int type, unsigned long begin,
> > struct address_space *address_space = swap_address_space(entry);
> > XA_STATE(xas, &address_space->i_pages, curr);
> >
> > + xas_set_update(&xas, workingset_update_node);
> > +
> > xa_lock_irq(&address_space->i_pages);
> > xas_for_each(&xas, old, end) {
> > if (!xa_is_value(old))
>
> Adding xas_set_update() call?
It makes perfect sense to me.
> In any case, please explain what you are doing above in imperative mood
> (no "This patch does foo" but "Do foo" instead).
Not helpful either.
