Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 11 Jan 2023 23:55:51 -0800
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <167344728530.2425628.9613910866466387722.stgit@warthog.procyon.org.uk>
References: <167344725490.2425628.13771289553670112965.stgit@warthog.procyon.org.uk> <167344728530.2425628.9613910866466387722.stgit@warthog.procyon.org.uk>

> +	BUG(); // if it had been empty, we wouldn't get called

Please use a normal /* */ comment here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v5 0/9] iov_iter: Add extraction helpers
  - From: David Howells
- [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator
  - From: David Howells

Prev by Date: Re: [linus:master] [mm, slub] 0af8489b02: kernel_BUG_at_include/linux/mm.h
Next by Date: Re: [PATCH 0/4] Track exported dma-buffers with memcg
Previous by thread: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator
Next by thread: Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux